Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repository generator tests #73

Open
wants to merge 42 commits into
base: master
Choose a base branch
from

Conversation

KonstantinLapkovsky
Copy link

Issue #49

@KonstantinLapkovsky KonstantinLapkovsky changed the base branch from master to 49-cover-entity-generator-with-tests December 21, 2023 17:05
t0xas and others added 19 commits November 20, 2024 16:06
# Conflicts:
#	tests/ControllerGeneratorTest.php
#	tests/NovaResourceGeneratorTest.php
#	tests/NovaTestGeneratorTest.php
#	tests/Support/Controller/ControllerMockTrait.php
#	tests/Support/NovaResource/NovaResourceMockTrait.php
#	tests/Support/NovaTest/NovaTestMockTrait.php
#	tests/Support/Shared/GeneratorMockTrait.php
#	tests/TestCase.php
…erator-tests

# Conflicts:
#	tests/Support/Factory/FactoryMockTrait.php
…to 49-add-repository-generator-tests

# Conflicts:
#	phpunit.xml
#	tests/FactoryGeneratorTest.php
#	tests/Support/NovaTest/NovaTestMockTrait.php
…into 49-add-repository-generator-tests

# Conflicts:
#	tests/Support/NovaTest/NovaTestMockTrait.php
…to 49-add-repository-generator-tests

# Conflicts:
#	tests/Support/NovaTest/NovaTestMockTrait.php
@pirs1337 pirs1337 changed the base branch from 49-cover-entity-generator-with-tests to master December 19, 2024 12:05
@pirs1337 pirs1337 assigned DenTray and unassigned pirs1337 Dec 19, 2024
@DenTray
Copy link
Collaborator

DenTray commented Dec 23, 2024

@pirs1337 please assign this one after merging model generation test

@DenTray DenTray assigned pirs1337 and unassigned DenTray Dec 23, 2024
Copy link
Collaborator

@DenTray DenTray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pirs1337 let's make review after model test will me merged and master branch will be merged into this one


$this->assertExceptionThrew(
className: ClassNotExistsException::class,
message: "Cannot create Post Model cause Post Model does not exists. "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check exception message, seems we need to throw next text

Suggested change
message: "Cannot create Post Model cause Post Model does not exists. "
message: "Cannot create PostRepository cause Post Model does not exists. "


trait RepositoryMockTrait
{
use GeneratorMockTrait, MockTrait;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could GeneratorMockTrait use MockTrait directly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants