-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add repository generator tests #73
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # phpunit.xml # tests/Support/NovaTestMockTrait.php
# Conflicts: # tests/ControllerGeneratorTest.php # tests/NovaResourceGeneratorTest.php # tests/NovaTestGeneratorTest.php # tests/Support/Controller/ControllerMockTrait.php # tests/Support/NovaResource/NovaResourceMockTrait.php # tests/Support/NovaTest/NovaTestMockTrait.php # tests/Support/Shared/GeneratorMockTrait.php # tests/TestCase.php
…erator-tests # Conflicts: # tests/Support/Factory/FactoryMockTrait.php
…' into 49-add-model-generator-tests
refs: #49
…' into 49-add-model-generator-tests
…to 49-add-repository-generator-tests # Conflicts: # phpunit.xml # tests/FactoryGeneratorTest.php # tests/Support/NovaTest/NovaTestMockTrait.php
…' into 49-add-model-generator-tests
…' into 49-add-model-generator-tests
refs: #49
refs: #49
…into 49-add-repository-generator-tests # Conflicts: # tests/Support/NovaTest/NovaTestMockTrait.php
refs: #49
refs: #49
refs: #49
refs: #49
…to 49-add-repository-generator-tests # Conflicts: # tests/Support/NovaTest/NovaTestMockTrait.php
refs: #49
@pirs1337 please assign this one after merging model generation test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pirs1337 let's make review after model test will me merged and master branch will be merged into this one
|
||
$this->assertExceptionThrew( | ||
className: ClassNotExistsException::class, | ||
message: "Cannot create Post Model cause Post Model does not exists. " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check exception message, seems we need to throw next text
message: "Cannot create Post Model cause Post Model does not exists. " | |
message: "Cannot create PostRepository cause Post Model does not exists. " |
|
||
trait RepositoryMockTrait | ||
{ | ||
use GeneratorMockTrait, MockTrait; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could GeneratorMockTrait use MockTrait directly?
Issue #49